From 73538e1a070c5e8b4fad4e9bd1e715bf2e35477e Mon Sep 17 00:00:00 2001
From: =?utf8?q?Felix=20K=C3=A4stner?=
 <4948415+fpunktk@users.noreply.github.com>
Date: Fri, 18 Feb 2022 15:31:41 +0100
Subject: [PATCH] improve compression and messaging

---
 README.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/README.md b/README.md
index 992ad74..db7dc5d 100644
--- a/README.md
+++ b/README.md
@@ -66,17 +66,17 @@ minify-trc() {
 trccmd() {
     # echo all the commands to travel with rc files, arguments act as additional arguments to tar
     local trc_min_dir="$(minify-trc)"
-    echo -n "packing trcdir... " >&2
+    echo -n "packing trcdir with '$*'... " >&2
+    [ -n "$1" ] || set -- "--gzip" # default compression is gzip (when no argument is set), can be disabled with "-a" which leads to no compression
     local trcvar="$(tar --create --file=- "$@" --directory="$trc_min_dir" --dereference ./ | base64 --wrap=0)" # this writes the compressed contents of $trc_min_dir base64-encoded to $trcvar
     rm -rf "$trc_min_dir" # delete the temporal directory generated by minify-trc
     echo "to ${#trcvar} bytes... " >&2
-    [ ${#trcvar} -lt 65536 ] || { echo "content of trcdir \"$trcdir\" is too big, even after minifying" >&2; return 1; }
+    [ ${#trcvar} -lt 65536 ] || { echo "ERROR: content of trcdir '$trcdir' is too big, even after minifying and compressing with '$*'" >&2; return 1; }
     # export $TRAVELRCDIR and create this directory, it could also be created in /tmp
     echo '
 export TRAVELRCDIR=$HOME/.travelrc.travelled
 readonly TRAVELRCDIR
-mkdir --parents $TRAVELRCDIR
-'
+mkdir --parents $TRAVELRCDIR'
     # SSH_TTY should still be set to figure out whether this is a ssh session
     [ -z "$SSH_TTY" ] || echo "export SSH_TTY=$SSH_TTY"
     # decompress the files saved to $trcvar; start a bash with the travelled rc-file; only remove $TRAVELRCDIR if there is no screen or tmux session (which can still use the files); last command is true so that the returncode is always 0
-- 
2.30.2